Fix nodeType check in fragment.js #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops thanks for catching this! If you don't mind - can you work on the dev branch and merge against dev branch (currently it's master -> master) ? You probably need to open a new PR to do that. |
|
Sorry, but I just realized this check would ignore textNode as well. Also, in the next branch comment nodes will serve certain purposes as well, so the best thing to do is probably just remove the check all together. |
|
I see, ok, I can do a little PR against the dev branch that just removes the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appending multiple child nodes to the fragment, there is a check for each node to ensure it has a
nodeType === 1, however, the check was being performed repeatedly on the wrappernodeinstead.