[EXPERIMENTAL] Try to really improve flowtype #4567
Merged
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The primary reason for the use of I don't think it's possible or particularly important to have full type coverage, since the whole point of Flow is gradual typing. The goal of introducing Flow in the codebase is to leverage it when we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment striving to fix #4410. The improvement is based on CLI tool. The following command is used to inspect source.
Which prints out all the line number of potential unsound
anytype. Only files undersrc/compiler/codegen/are checked.To my consternation, we have a lot of
implictAnyin code base, (and I have no idea why). Fixing theseanyneeds some weird typing and dependency on how flow works (in my conjecture).While I really appreciate @thejameskyle 's suggestion, I'm afraid maybe our team's capability does not match Flow's type system.
As the title indicates, this pull request is experimental, feel free to close it.