Skip to content

Recommend user to provide reproduction repository for ssr issue #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 27, 2016
Merged

Recommend user to provide reproduction repository for ssr issue #4573

merged 3 commits into from
Dec 27, 2016

Conversation

defcc
Copy link
Member

@defcc defcc commented Dec 26, 2016

For SSR issue, it's better to recommend the user to privide reproduction repository.

@@ -28,7 +28,7 @@ Hi! I’m really excited that you are interested in contributing to Vue.js. Befo

- It is recommended that you make a JSFiddle/JSBin/Codepen to demonstrate your issue. You could start with [this template](http://jsfiddle.net/df4Lnuw6/) that already includes the latest version of Vue.

- For bugs that involves build setups, you can create a reproduction repository with steps in the README.
- For potential SSR(Server Side Rendering) issue or bugs that involves build setups, you can create a reproduction repository with steps in the README.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor: can we add a space between SSR and the paren ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll make an update.

@yyx990803 yyx990803 merged commit f5f8453 into vuejs:dev Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants