Skip to content

[weex] Support unary and left open tags #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2017
Merged

Conversation

Hanks10100
Copy link
Contributor

Fix weexteam/vue-loader-for-apache-weex#8 .

And add more reserved tags.

@yyx990803
Copy link
Member

yyx990803 commented Mar 3, 2017

I'm not sure if this actually fixes it. Currently html-parser.js is hard coded to use canBeLeftOpenTag from platforms/web: https://github.com/vuejs/vue/blob/dev/src/compiler/parser/html-parser.js#L13

We will need to change the compiler to pass on canBeLeftOpenTag as an option to parser/index, and then pass it on to html-parser. The web compiler entry also needs to be updated.

@Hanks10100
Copy link
Contributor Author

Actually only need to implement the isUnaryTag can fix that bug. I also add a test case for using unary tag in Weex.

Anyway, I also moved canBeLeftOpenTag to the compiler option, it can be passed form entry. The baseOptions of web compiler and the flow type of CompilerOptions has also been updated.

@yyx990803 yyx990803 added the weex label Mar 10, 2017
@yyx990803 yyx990803 merged commit 2944515 into vuejs:dev Mar 15, 2017
@Hanks10100 Hanks10100 deleted the unary-tag branch March 16, 2017 02:36
awamwang added a commit to awamwang/vue that referenced this pull request Mar 16, 2017
* 'dev' of https://github.com/vuejs/vue: (118 commits)
  [weex] Support unary and left open tags (vuejs#5052)
  [release] 2.2.4
  [build] 2.2.4
  fix perf measure regression for nested components of the same name (fix vuejs#5181)
  [release] 2.2.3
  [build] 2.2.3
  perf code coverage
  improve camelCase prop warning message
  warn when template contains text outside root element (vuejs#5164)
  Warn when not passing props in kebab-case (vuejs#5161)
  turn off perf timeline measuring by default + reduce its impact on dev time perf (fix vuejs#5174)
  v-bind object should have lower priority than explicit bindings (fix vuejs#5150)
  fix custom directive arg fall through (fix vuejs#5162)
  formatting tweaks
  refactor create-component
  fix wrong order of generate modifier code (vuejs#5147)
  fix v-on unit test (vuejs#5144)
  fix vuejs#5121: parse content in textarea as plaintext (vuejs#5143)
  [release] 2.2.2
  [build] 2.2.2
  ...

# Conflicts:
#	dist/vue.runtime.common.js
#	src/core/vdom/helpers/update-listeners.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants