Skip to content

fix mouse modifier override the keycode ( Fixed #5046 ) #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix mouse modifier override the keycode ( Fixed #5046 ) #5060

wants to merge 2 commits into from

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Mar 2, 2017

@posva
Copy link
Member

posva commented Mar 2, 2017

ping @yyx990803 This PR fixes a regression

@yyx990803
Copy link
Member

Thanks, figured out a better way to keep the same usage by checking 'button' in $event in 3294eba

@yyx990803 yyx990803 closed this Mar 3, 2017
@Kingwl Kingwl deleted the dev-fix-mouse-modifier branch March 3, 2017 03:45
@ghost ghost mentioned this pull request Nov 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kingwl @posva @yyx990803 @kazupon