Skip to content

chore(parser.spec): fix an IE conditional test with a typo #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2017

Conversation

S-YOU
Copy link
Contributor

@S-YOU S-YOU commented Mar 6, 2017

Please check if the PR fulfills these requirements

If adding new feature:

  • Added accompanying test case.
  • In the commit message, provide convincing reason to add this feature.
    Ideally you should open a suggestion issue first and have it greenlighted before working on it.

If fixing a bug:

  • If you are resolving a special issue, add (fix #xxxx[,#xxx]) (#xxxx is the issue id) in your PR title
  • Provide detailed description of the bug in the PR. Live demo preferred.
  • Add appropriate test coverage if applicable.

What kind of change does this PR introduce? (check at least one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactoring
[ ] Build related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:
This is unconfirmed, since I don't have IE at the moment.

@posva
Copy link
Member

posva commented Mar 6, 2017

I think we want the test to work when it's not IE too so we know the parser can handle it, but I may be wrong

@S-YOU
Copy link
Contributor Author

S-YOU commented Mar 6, 2017

@posva, The test fail somehow on my machine. Since it is a parser, I am afraid that it would fail on IE too.

@S-YOU S-YOU force-pushed the parser_ie_conditional_test branch from 6cc8726 to 4e5dc09 Compare March 6, 2017 09:31
@S-YOU
Copy link
Contributor Author

S-YOU commented Mar 6, 2017

@posva, @kazupon, I have changed to use children.length to be 0, instead of run only on IE.
But still actual behavaior on IE is unconfirmed, since I don't have it.

@yyx990803 yyx990803 merged commit e12d96a into vuejs:dev Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants