Minimize size of bootstrap used in dbmon benchmark #5123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the bootstrap file used was directly copied from https://github.com/mathieuancelin/js-repaint-perfs , but they have since removed the dependency on bootstrap. I think we can just use this file instead. |
d1d4fa1 to
99d8b9e
Compare
|
@yyx990803 thanks for pointing that out. I have made that change, and updated OP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one with "x")
Does this PR introduce a breaking change? (check one with "x")
Other information:
In #5029 I outlined how the bootstrap library that is used in the dbmon benchmark references font files that are not included in the repo.
Rather than including them in the repo I thought a better approach would be to customize the bootstrap library to only include exactly what the benchmark actually needed.
The customization options are stored, by bootstrap, in the minified file. For quick reference you can find it here.
Size of the library goes from 102KB to 49KB.
This resolves my original problem as the "Glyphicons" module of bootstrap is no longer included and the references to fonts have been removed from the library.
Update based on comments:
This PR now removes the bootstrap library that the js-repaint-perfs library was using in favour of using the
styles.cssthat the library now uses.