Skip to content

handle v-model on password input field on ie9 (fix #5250) #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Mar 22, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Other information:

On IE9, we are currently marking vmodel flag in real DOM and virtually trigger input event when selectionchange is triggered by the element. But input[type=password] element is not set vmodel flag since it does not match the condition.

BTW, should we also add conditions for other input types that can be input texts like search, url and so on?

@yyx990803 yyx990803 merged commit 70db229 into vuejs:dev Mar 23, 2017
@ktsn ktsn deleted the ie9-input-password branch March 23, 2017 04:12
awamwang pushed a commit to awamwang/vue that referenced this pull request Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants