Skip to content

improve:add local variable declaration #5462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

gebilaoxiong
Copy link
Member

@gebilaoxiong gebilaoxiong commented Apr 17, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Add the declaration of the local variable i in removeAndInvokeRemoveHook

@yyx990803 yyx990803 merged commit 3b4d16b into vuejs:dev Apr 18, 2017
@gebilaoxiong gebilaoxiong deleted the add_local_variable_declaration branch April 18, 2017 04:21
@gebilaoxiong
Copy link
Member Author

It seems to be because the outer variable i caused
so lint did not trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants