Skip to content

fix mixin issue(fix vuejs/vue-class-component#87) #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

mj-hd
Copy link

@mj-hd mj-hd commented Apr 25, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:
This patch fixes vuejs/vue-class-component#87 issue.
This includes following changes:

  • Fixing the problem that Mixing feature drops original lifecycle hooks.
  • Its test code.

In my environment, some e2e tests failed. But these tests also fail without my modifications.

@yyx990803 yyx990803 merged commit 12b7122 into vuejs:dev Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beforeDestroy not invoked
3 participants