Return empty string for Infinity and properly format values such as 0.999 #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Would it be weird to have |
|
Thanks for response. That's interesting question. Here is my thoughts: Also I made this test with AngularJS, it prints empty string: http://jsfiddle.net/41Lga6bg/ |
| sign = sign || '$' | ||
| var s = Math.floor(Math.abs(value)).toString(), | ||
| i = s.length % 3, | ||
| h = i > 0 | ||
| ? (s.slice(0, i) + (s.length > 3 ? ',' : '')) | ||
| : '', | ||
| f = '.' + value.toFixed(2).slice(-2) | ||
| v = Math.abs(parseInt((value * 100) % 100, 10)), |
|
Sounds good, it's probably a good idea to keep the filter consistent with Angular's implementation. |
yyx990803
added a commit
that referenced
this pull request
Feb 21, 2015
Return empty string for Infinity and properly format values such as 0.999
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in currency filter (demo for both: http://jsfiddle.net/k5bv3r62/ ):
x.999 values are shown as $x.00
Say you have model with value 0.999. With currency filter applied it will be shown as $0.00
Infinity value show as $In,finity.ty
I think, it would be good to return empty string as for falsy values
Also I added new test cases for described issues.