make example of vm ready bug in phantom.js #764
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yyx990803 this doesn't seem to be a bug in the browser, but from phantom.js. I would expect the ready function for a child component to fire when running in phantom / casper, but it seems that it is not. I think the culprit is util.inDoc returning false. So maybe the version of webkit that phantom / casper use doesn't support document.documentElement.contains (at least for comments)?
One thing to note is that I am using windows...
overriding util.inDoc with $.contains seems to fix it. I'm gonna try to find a better way though.