Updated README. Call next() inside vue route hook to confirm navigation #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
suggested changes
Sep 3, 2018
README.md
Outdated
| @@ -169,12 +169,14 @@ import Component from 'vue-class-component' | |||
| class MyComp extends Vue { | |||
| // The class component now treats beforeRouteEnter | |||
| // and beforeRouteLeave as Vue Router hooks | |||
| beforeRouteEnter () { | |||
| beforeRouteEnter (to: Route, from: Route, next: Function) { | |||
There was a problem hiding this comment.
Please remove type annotations since this snippet is JavaScript.
README.md
Outdated
| console.log('beforeRouteEnter') | ||
| next(); // needs to be called to confirm the navigation |
There was a problem hiding this comment.
Please follow existing code styling (prefer 2 spaces than hard tab, no semi-colons)
|
Fixed codereview remarks. |
ktsn
approved these changes
Sep 4, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call next() inside vue-route hooks (i.e beforeRouteEnter and beforeRouteLeave) to confirm navigation otherwise route is not rendered.