Skip to content

fix: when script has no attributes #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2018
Merged

fix: when script has no attributes #1628

merged 2 commits into from
Jul 11, 2018

Conversation

snadn
Copy link
Contributor

@snadn snadn commented Jun 20, 2018

when use webpack htmlWebpackIncludeAssetsPlugin include script. the script has no attributes, and build throw error.

image

@snadn
fix: when script has no attributes
8480b07 
when use webpack `htmlWebpackIncludeAssetsPlugin` include script. the script has no attributes, and build throw error.
@Akryum Akryum requested a review from yyx990803 June 28, 2018 21:13
@snadn
Copy link
Contributor Author

snadn commented Jul 11, 2018

what about this pr? @Akryum @yyx990803

@Akryum Akryum merged commit b1331ee into vuejs:dev Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snadn @Akryum