Skip to content

Fix #1735 #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Fix #1735 #1736

merged 1 commit into from
Jul 3, 2018

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Jul 3, 2018

Don't use ES6 in code that we inject into --lib builds
closes #1735

@yyx990803 yyx990803 merged commit d601441 into dev Jul 3, 2018
@LinusBorg LinusBorg deleted the LinusBorg-patch-issue-1735 branch July 4, 2018 15:32
@antopravin
Copy link

Hi,
Due to this problem, We aren't able to roll out a release to support ios9 devices.
May I know when to expect this fix to be released?

@LinusBorg
Copy link
Member Author

We don't have a specific date yet, but it should be very shortly, in the next couple of days, maybe a little over a week, would you agree @Akryum ?

As a workaround you should be able to add vue-cli-service to transpileDependencies I think. Can you try this?

@antopravin
Copy link

Thanks for the suggestion. But let me clarify,
I assume you expect me to add this in package.json. right?

"transpileDependencies":{
"vue-cli-service":"^3.0.0-beta.6"
}

@LinusBorg
Copy link
Member Author

No, its an option in vue.config.js

See here: https://cli.vuejs.org/config/#transpiledependencies

@antopravin
Copy link

When i include transpileDependencies in vue.config.js, I get below error:
Invalid options in vue.config.js: "transpileDependencies" is not allowed

@LinusBorg
Copy link
Member Author

LinusBorg commented Jul 11, 2018

That option didn't exist yet in beta.6, you should upgrade either way

@antopravin
Copy link

antopravin commented Jul 11, 2018

hmm, may be, here are the dependencies

"@vue/cli-plugin-babel": "^3.0.0-beta.6",
"@vue/cli-plugin-e2e-nightwatch": "^3.0.0-beta.6",
"@vue/cli-plugin-eslint": "^3.0.0-beta.6",
"@vue/cli-plugin-unit-jest": "^3.0.0-beta.6",
"@vue/cli-service": "^3.0.0-beta.6",
"@vue/eslint-config-standard": "^3.0.0-beta.6",

@LinusBorg
Copy link
Member Author

After beta.6 came another 10 beta releases, and now we are on the 3rd Release Candidate.

@antopravin
Copy link

oh ok. I will try updating them to 3rd release candidate

@antopravin
Copy link

Updated the vue cli to version:3.0.0-rc.3

After including below in vue.config.js

transpileDependencies: ['@vue/cli-service'] or
transpileDependencies: ['vue-cli-service'],
I still see 'let' being used in setPublicPath.js under node_modules/@vue/cli-service/lib/command/build

So including transpileDependencies option on the vue-config didn't seem to work, unless I have done something wrong.
As this is top priority for us, it would be great to see any other work arounds that we could try, thanks for you support so far.

@yyx990803
Copy link
Member

yyx990803 commented Jul 13, 2018

The latest version is rc.4. This PR is not in rc.3.

@antopravin
Copy link

antopravin commented Jul 13, 2018

Thanks a lot that seemed to fix the let on the setPublicPath.js.
But I can still see a let being used on the minified version in file: dist/js/vendor.db846e77.js
let t;(t=window.document.currentScript)

@LinusBorg
Copy link
Member Author

LinusBorg commented Jul 13, 2018

I'm not aware of other code that we inject, so this could be coming from any of your project's dependencies.

Can you provide a reproduction?

@antopravin
Copy link

antopravin commented Jul 13, 2018

You are right!
The issue is due to transitive dependencies of old Vue-cli-service versions in our package.json.
We'll work with the teams to get them updated to RC4 version of Vue-cli-service.
Thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Library-Build contains ES6 language
4 participants