added options and updated readme #1752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
requested changes
Jul 4, 2018
Akryum
requested changes
Jul 4, 2018
| @@ -53,6 +53,34 @@ file, or the `"vue"` field in `package.json`. | |||
|
|
|||
| - Default: `'default'` | |||
|
|
|||
| - **pwa.iconVersion** | |||
There was a problem hiding this comment.
I would rename this to pwa.assetsVersion since it's not just icons.
Akryum
approved these changes
Jul 4, 2018
Akryum
reviewed
Jul 4, 2018
|
|
||
| This option is used if you need to add a version to your incons and manifest, against browser’s cache. This will append `?v=<pwa.assetsVersion>` to the URLs of the icons and manifest. | ||
|
|
||
| - **pwa.manifestPath** |
There was a problem hiding this comment.
We have to think about how to manage this in the UI, the PWA configuration screens attempts to load and write to this file. If the user changes the location, it will break it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added options (please view README.md for more info) to have a better control over the favicons and app icons generation.