Skip to content

fix(create): Commands added by plugin (through preset) won't have description in README #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

fix(create): Commands added by plugin (through preset) won't have description in README #1910

merged 1 commit into from
Jul 24, 2018

Conversation

pksunkara
Copy link
Contributor

@pksunkara pksunkara commented Jul 21, 2018 •
edited
Loading

For example, if my preset has vue-cli-plugin-s3-deploy, then when the project is created, my README contains the following:

### undefined

```
npm run deploy
```

While my package.json has the following:

"scripts": {
  "deploy": "vue-cli-service s3-deploy"
}

@pksunkara pksunkara changed the title fix(create): Commands added by plugin (through preset) won't have des… fix(create): Commands added by plugin (through preset) won't have description in README Jul 21, 2018
@yyx990803 yyx990803 merged commit e9d01eb into vuejs:dev Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pksunkara @kazupon @Akryum @yyx990803