Skip to content

fix(cli-ui): ignore "false" ENOENT errors on Windows #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

fix(cli-ui): ignore "false" ENOENT errors on Windows #2294

merged 1 commit into from
Aug 21, 2018

Conversation

lbogdan
Copy link
Contributor

@lbogdan lbogdan commented Aug 20, 2018

Fixes #2096 .

See this comment:

Another approach would be to consider the command execution duration - if we're on Windows and we get a ENOENT after more than 1 second, it's most probably a "false" one (this will not cover the case where you press on start and immediately on stop; a workaround would be to disable the button for 1s after starting a task).

@yyx990803 yyx990803 requested a review from Akryum August 20, 2018 15:39
@Akryum Akryum merged commit bf91533 into vuejs:dev Aug 21, 2018
@lbogdan lbogdan deleted the fix/win-exec-enoent branch August 21, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbogdan @Akryum