Skip to content

fix: use yarn --version to detect yarn #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

fix: use yarn --version to detect yarn #4336

merged 1 commit into from
Jul 23, 2019

Conversation

haoqunjiang
Copy link
Member

  • We never referred to yarnpkg anywhere else in the codebase
  • For the rare case that yarn binary is overridden by Hadoop YARN,
    yarn --version will throw (it only supports yarn version), therefore
    it won't pass this check.

Fixes #3941.
Closes #3942.

@haoqunjiang
fix: use yarn --version to detect yarn
6218048 
- We never referred to `yarnpkg` anywhere else in the codebase
- For the rare case that `yarn` binary is overridden by Hadoop YARN,
`yarn --version` will throw (it only supports `yarn version`), therefore
it won't pass this check.

Fixes vuejs#3941.
@haoqunjiang haoqunjiang merged commit 448dbdb into vuejs:dev Jul 23, 2019
haoqunjiang added a commit that referenced this pull request Aug 2, 2019
@haoqunjiang
fix: use yarn --version to detect yarn (#4336)
470c94e 
- We never referred to `yarnpkg` anywhere else in the codebase
- For the rare case that `yarn` binary is overridden by Hadoop YARN,
`yarn --version` will throw (it only supports `yarn version`), therefore
it won't pass this check.

Fixes #3941.
Closes #3942.

(cherry picked from commit 448dbdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkyarn fails on Solus
1 participant
@haoqunjiang