Skip to content

Conversation

sarbikbetal
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
Added a small fix related to PWAs deployed on Netlify. If you don't exclude the _redirects file, the service worker will try to cache it but it won't be able to find the file in the netlify servers and as a result the service worker installation will fail, which will break all the PWA functionalities, so we need to exclude the file through workbox exclude option.

Added a small fix related to PWAs deployed on Netlify. If you don't exclude the `_redirects` file, the service worker will try to ache it but it won't be able to find the file in the netlify servers and as a result the service worker installation will fail, which will break all the PWA functionalities
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haoqunjiang haoqunjiang merged commit 145ccca into vuejs:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants