Skip to content

fix(cli-plugin-typescript): Remove legacy code #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bodograumann
Copy link
Contributor

The code originally disabled the prompt about choosing tslint, but that prompt was already removed from the code, so now it disables the wrong prompt. This bug has even been there since other prompts where inserted before the tslint-prompt and it was not at position 2 anymore.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

The code originally disabled the prompt about choosing `tslint`, but that prompt was already removed from the code, so now it disables the wrong prompt.
@bodograumann
Copy link
Contributor Author

bodograumann commented Nov 13, 2020

It might also be possible to revert other changes from e33b04c, but I couldn't say for sure.

@haoqunjiang
Copy link
Member

Closing in favor of #6053 as it also fixed a lint error. But thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants