Skip to content

Wrong directory name #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2016
Merged

Wrong directory name #87

merged 3 commits into from
Apr 27, 2016

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented Apr 27, 2016

Fixes #86.

Although I was thinking we might rather do this

var data = extend({}, metalsmith.metadata(), { destDirName: name })

and also update https://github.com/vuejs-templates/webpack/blob/dist/meta.json to use destDirName inside completeMessage.

@yyx990803
Copy link
Member

That makes sense - I've invited you to the templates organization so you can change both places at the same time. LGTM.

zigomir added a commit to vuejs-templates/webpack that referenced this pull request Apr 27, 2016
vuejs/vue-cli#87

- direct commit since this is not master branch
@zigomir
Copy link
Contributor Author

zigomir commented Apr 27, 2016

@yyx990803 All right, I renamed it here and in template. Now we should merge this and publish new version imo.

@yyx990803 yyx990803 merged commit 9c4e6b4 into vuejs:master Apr 27, 2016
@yyx990803
Copy link
Member

published 2.0.3.

@zigomir zigomir deleted the wrong-directory-name branch February 22, 2018 17:59
wdev733 added a commit to wdev733/vue-dashboard that referenced this pull request Aug 6, 2019
vuejs/vue-cli#87

- direct commit since this is not master branch
fullstack412 added a commit to fullstack412/Vue-dashboard that referenced this pull request Aug 16, 2019
vuejs/vue-cli#87

- direct commit since this is not master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants