Skip to content

use route-cache middleware for microCache #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2017
Merged

use route-cache middleware for microCache #246

merged 2 commits into from
Sep 1, 2017

Conversation

bradoyler
Copy link
Contributor

@yyx990803 Thought this might clean things up a bit. 😉

yyx990803
yyx990803 requested changes Sep 1, 2017
View reviewed changes
server.js Outdated
maxAge: 1000
})

// since this app has no user-specific content, every page is micro-cacheable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we preserve this block of comment? It's still necessary to remind users that you cannot microcache in every case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added back 👍

@yyx990803 yyx990803 merged commit 6c70f41 into vuejs:master Sep 1, 2017
@yyx990803
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradoyler @yyx990803