Improve UI by adding 2nd paginator and making 1st one movable #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Come on, this is the only one old and unmerged PR, let's finish this! :) I'll show you the improvement in gifs:
A bit handier, isn't it? :) Especially for smaller devices where there's not so much vertical space. We should always keep UX in mind and optimize vertical space usage. |
yyx990803
requested changes
Jan 17, 2017
| @@ -16,11 +10,13 @@ | |||
| </transition-group> | |||
| </div> | |||
| </transition> | |||
| <newsListNav :page="page" :maxPage="maxPage" :type="type" v-if="displayedPage > 0"></newsListNav> | |||
There was a problem hiding this comment.
Can we use kebab-case here to keep it consistent with the rest of the project?
|
Hey sorry for letting this sit for so long - the gif helps a lot, looks great. Just a minor code style change needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement is useful for all users as we're using vertical space more efficiently. Especially it is important for mobile devices.