fix: fix hot-reload not working after options get modified #77
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
reviewed
Sep 10, 2019
|
This change looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
msginsrc/app.vue, hot reload works fine.msginsrc/app.vue, hot reload works fine.msginsrc/app.vueagain, hot reload stop working.What happened here?
Vue Devtools will patch the existed component options when it gets activated, which caused this line to be run. As a result,
record.options._Ctoris now pointing tonewCtor.options._Ctor, which breaks the connection betweenrecord.Ctorandrecord.optionsand cause hot-reload failure.