Fix for 'loader.charAt is not a function' in v8 #1166
Conversation
I have some older project still runnig on Vue 1 and crash on 'loader.charAt is not a function' error like in the vuejs#624 issue. I am not javascript expert, but this edit solve my issue and maybe can solve also for other.
There was a problem hiding this comment.
vue-loader@14+ does no longer support webpack 1 any more. https://github.com/vuejs/vue-loader/releases/tag/v14.0.0 ~
~ If you really want to fix it for webpack 1, I suggest you re-create a PR to branch 13.x https://github.com/vuejs/vue-loader/tree/13.x and with good test cases.
Sorry I misunderstand some detail. But test case is still strongly recommended.
Thanks.
|
Thanks for reply. I am not quite similiar with javascript testing but I can look at it.. Btw. same logic I added here (8.x is last loader for Vue 1) you can found in version 12 here https://github.com/vuejs/vue-loader/blob/v12/lib/loader.js#L484 . The function is same. Maybe can you found test there. :) |
|
So I am not able to test this, I am sorry. I clone this repo. Switch the branch to 8x, run npm install and npm test. Even without this issue I end up with 6+ failing tests. So I do not know how fix all this tests and even write this new one. If this can not be able to merged without test, maybe we can close it. But same logic is used in newer version and for me this fix the issue 'loader.charAt is not a function'. |
|
OK, that's alright. I will have a deep look at it. :-) |
I have some older project still runnig on Vue 1 and crash on 'loader.charAt is not a function' error like in the #624 issue.
I am not javascript expert, but this edit solve my issue and maybe can solve also for other.