[v14] fix: Explicitly set the prettier parser to 'babylon' #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since as of Prettier 1.13.0 there is no longer a default: prettier/prettier#4528 The `parser` option has been supported since prettier v0.0.10, so this won't break users whose lockfile still references a pre-1.13.0 release of prettier: https://github.com/prettier/prettier/blob/1.13.0/src/main/core-options.js#L89 This is the `v14` branch backport of: vuejs/component-compiler-utils#15
|
Many thanks :-) |
This was referenced May 28, 2018
edmorley
added a commit
to neutrinojs/neutrino
that referenced
this pull request
May 28, 2018
To fix the Vue preset failures on master due to the Prettier breaking API change in 1.13.0: vuejs/component-compiler-utils#15 vuejs/vue-loader#1323 The lockfile has been updated manually since Renovate's weekly PR isn't currently working: renovatebot/renovate#2033 Fixes #913.
edmorley
added a commit
to neutrinojs/neutrino
that referenced
this pull request
May 28, 2018
To fix the Vue preset failures on master due to the Prettier breaking API change in 1.13.0: vuejs/component-compiler-utils#15 vuejs/vue-loader#1323 Closes #913.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since as of Prettier 1.13.0 there is no longer a default:
prettier/prettier#4528
The
parseroption has been supported since prettier v0.0.10, so this won't break users whose lockfile still references a pre-1.13.0 release of prettier:https://github.com/prettier/prettier/blob/1.13.0/src/main/core-options.js#L89
This is the
v14branch backport of:vuejs/component-compiler-utils#15
Whilst #1322 is the more important PR for us, since it will help fix the Neutrino 8 (stable) branch, this PR:
master(which is still using vue-loader 14 until we have a chance to update to v15),