shold emit webpack Error rather than throwing #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,18 +28,18 @@ module.exports = function (content) { | |||
| } | |||
|
|
|||
| if (!cons[opt.engine]) { | |||
| throw new Error( | |||
| emitError(new Error( | |||
There was a problem hiding this comment.
We should just call callback here with the error as the first argument. Also need to return early, so return callback(new Error('...'))
| @@ -27,19 +27,20 @@ module.exports = function (content) { | |||
| } | |||
|
|
|||
| if (!cons[opt.engine]) { | |||
| throw new Error( | |||
| callback(new Error( | |||
There was a problem hiding this comment.
we need to return here otherwise the code below will throw another error.
|
Thanks! |
hinablue
pushed a commit
to hinablue/vue-loader
that referenced
this pull request
Oct 3, 2016
* shold emit webpack Error rather than throwing * just callback can emit the error * should return
hinablue
pushed a commit
to hinablue/vue-loader
that referenced
this pull request
Oct 26, 2016
* shold emit webpack Error rather than throwing * just callback can emit the error * should return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent webpack crashing when templateLoader compiled errors.
vuejs/vue-cli#111