Skip to content

use Object.assign to merge cssModules configuration query with option #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2016
Merged

use Object.assign to merge cssModules configuration query with option #446

merged 1 commit into from
Nov 6, 2016

Conversation

JounQin
Copy link

@JounQin JounQin commented Nov 6, 2016

So that more options can be used instead of listing them specifically like camelCase.

And maybe there is no need to override the undefined localIdentName option which is passed customly.

@yyx990803
Copy link
Member

What's an example use case for this?

@JounQin
Copy link
Author

JounQin commented Nov 6, 2016 •
edited
Loading

If there is a class named ab-cd, and there is no camelCase option or it is false, we can only get the generated class name by $style['ab-cd'].

But when the camelCase is set to be true, we can get the class name by $style.abCd which is much better to write and 'js-style', and also $style['ab-cd'] is OK.

Camel case

@yyx990803 yyx990803 merged commit 0aa8a6e into vuejs:master Nov 6, 2016
@yyx990803
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JounQin @yyx990803