Skip to content

Add 'image' tag of SVG to 'transformToRequire` option as default #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2017
Merged

Add 'image' tag of SVG to 'transformToRequire` option as default #579

merged 4 commits into from
Jan 17, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jan 17, 2017

ref: #569 (comment)

@yyx990803 said 💬

We may consider adding this to default config.

@vuejs/vue-loader-vueify
Please review ! 👀

@yyx990803
Copy link
Member

👍

@yyx990803 yyx990803 merged commit 89cf9f3 into vuejs:master Jan 17, 2017
@blake-newman
Copy link
Member

@yyx990803 @kazupan

SVG also have the use tag that could also be added by default. This is used for SVG spritemaps.

Although with http 2 this becomes less relevant I still use this for icons ect.

@kazupon kazupon deleted the improve/transform branch January 30, 2017 09:32
xalexec pushed a commit to Transnal/vue-loader that referenced this pull request Mar 26, 2017
@kazupon @yyx990803
Add 'image' tag of SVG to 'transformToRequire` option as default (vue…
e85d6f5 
…js#579)

* add dev dependency module

* add 'image' tag to 'transformToRequire' option as default

Closes vuejs#569

* update doc

* add fixture
@mliew21396 mliew21396 mentioned this pull request Jan 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazupon @yyx990803 @blake-newman