Skip to content

fix cannot set css modules to vue instance #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2017
Merged

fix cannot set css modules to vue instance #609

merged 1 commit into from
Jan 31, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jan 30, 2017

Reference (Reproduction repo too): #592

In css modules, When we change styles, these styles can not set to Vue Instance due to cache of Vue Constructor.
I fixed this issue with using HMR API.

@yyx990803 yyx990803 merged commit cfcfc74 into vuejs:master Jan 31, 2017
@yyx990803
Copy link
Member

👍

@kazupon kazupon deleted the fixes/css-modules-updating branch January 31, 2017 03:30
xalexec pushed a commit to Transnal/vue-loader that referenced this pull request Mar 26, 2017
@kazupon @yyx990803
fix cannot apply css modules to vue instance (vuejs#609)
4254162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazupon @yyx990803