Skip to content

Improve the documentation site's title area #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2017
Merged

Improve the documentation site's title area #1574

merged 1 commit into from
Jul 8, 2017

Conversation

pearofducks
Copy link
Contributor

  • Adds the Vue icon to the browser titlebar instead of the Gitbook one
  • Changes the title to TOPIC • vue-router instead of TOPIC • Gitbook

posva
posva approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. If we add it we should also add it to vuex. WDYT @fnlctrl @yyx990803 @kazupon @ktsn

ktsn
ktsn approved these changes Jul 7, 2017
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pearofducks
Copy link
Contributor Author

pearofducks commented Jul 7, 2017 •
edited
Loading

@posva - PRs are on vuex and vue-loader for the same

@yyx990803 yyx990803 merged commit 137d381 into vuejs:dev Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@posva posva posva approved these changes

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pearofducks @kazupon @posva @ktsn @yyx990803