-
Notifications
You must be signed in to change notification settings - Fork 68
Improve on document check #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@clarkdo @atinux @yyx990803 for reference, here's the full log:
|
And
|
@yyx990803 We added a test to demonstrate: |
SSR shouldn't ever hit this code path. There's something wrong else where. |
@yyx990803 Interesting because the same project, with Nuxt 1.4.2 and VueStyleLoader 3.1.2 works! The scenario is loading ElementUI as a plugin in a SSR context. It works currently in my project with the aforementioned versions. When upgrading to Nuxt Edge (2.0) and VueStyleLoader 4.1.2, it starts giving me this error. I've looked long and hard through Nuxt's source code to try and pinpoint an error there, but it really does not seem to be doing anything wrong. |
@yyx990803 @atinux more info -- this is the line that causes it to fail:
from inside a Vue component in a Nuxt app. It works in 3.1.2 -- fails in 4.1.2. Now I'm puzzled if that's VueStyleLoader, Webpack or Nuxt that's getting something wrong. |
@yyx990803 @atinux so my best guess, after losing a day researching this, is that nested imports (from inside the
|
@yyx990803 so you were right :) -- thanks @atinux for looking into this |
@yyx990803 Nuxt Edge is failing for me with this error:
I traced it down to a SSR check that seems to be missing.