Skip to content

feat: add generic for wrapper.find() and wrapper.get() #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2021
Merged

feat: add generic for wrapper.find() and wrapper.get() #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
123f82a
feat: add generic for wrapper.find() and wrapper.get()
standbyoneself Jul 7, 2021
2391029
refactor: change HTMLElement -> Element
standbyoneself Jul 7, 2021
c899b38
fix: fix the tests for wrapper
standbyoneself Jul 7, 2021
1102c61
fix: forgot to apply the generic
standbyoneself Jul 7, 2021
3656299
test: added the simple test
standbyoneself Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/test-utils/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ interface BaseWrapper {
selector: Selector | void
}

export interface Wrapper<V extends Vue | null> extends BaseWrapper {
export interface Wrapper<V extends Vue | null, el extends Element = Element> extends BaseWrapper {
readonly vm: V
readonly element: HTMLElement
readonly element: el
readonly options: WrapperOptions

get<R extends Vue> (selector: VueClass<R>): Wrapper<R>
get<R extends Vue> (selector: ComponentOptions<R>): Wrapper<R>
get<Props = DefaultProps, PropDefs = PropsDefinition<Props>>(selector: FunctionalComponentOptions<Props, PropDefs>): Wrapper<Vue>
get (selector: string): Wrapper<Vue>
get<el extends Element>(selector: string): Wrapper<Vue, el>
get (selector: RefSelector): Wrapper<Vue>
get (selector: NameSelector): Wrapper<Vue>

Expand All @@ -96,7 +96,7 @@ export interface Wrapper<V extends Vue | null> extends BaseWrapper {
find<R extends Vue> (selector: VueClass<R>): Wrapper<R>
find<R extends Vue> (selector: ComponentOptions<R>): Wrapper<R>
find<Props = DefaultProps, PropDefs = PropsDefinition<Props>>(selector: FunctionalComponentOptions<Props, PropDefs>): Wrapper<Vue>
find (selector: string): Wrapper<Vue>
find<el extends Element>(selector: string): Wrapper<Vue, el>
find (selector: RefSelector): Wrapper<Vue>
find (selector: NameSelector): Wrapper<Vue>

Expand Down
4 changes: 3 additions & 1 deletion packages/test-utils/types/test/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ wrapper.findComponent(ClassComponent)
wrapper.vm.foo
wrapper.vm.$emit('event', 'arg')

let el: HTMLElement = wrapper.element
let el: Element = wrapper.element

let selector: Selector | void

Expand All @@ -68,6 +68,8 @@ selector = found.selector
found = wrapper.find({ name: 'my-button' })
selector = found.selector

wrapper.find<HTMLInputElement>('input').element.value

let array = wrapper.findAll('.bar')
selector = array.selector
array = wrapper.findAll(normalOptions)
Expand Down