Skip to content

Feature/allow additional plugin #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/allow additional plugin #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38127a6
feat: possibility to add plugins to the vue instance
Marujah Mar 8, 2022
13ad7ef
feat: allow adding plugins like pinia/vuex to rendered web component
Marujah Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions dist/vue-wc-wrapper.global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function getAttributes (node) {
return res
}

function wrap (Vue, Component) {
function wrap (Vue, Component, plugin) {
const isAsync = typeof Component === 'function' && !Component.cid;
let isInitialized = false;
let hyphenatedPropsList;
Expand Down Expand Up @@ -167,12 +167,21 @@ function wrap (Vue, Component) {
);
}

const _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };

function _isObjectEmpty(obj) {
return (
Object.prototype.toString.call(obj) === '[object Object]' &&
JSON.stringify(obj) === '{}'
);
}

class CustomElement extends HTMLElement {
constructor () {
const self = super();
self.attachShadow({ mode: 'open' });

const wrapper = self._wrapper = new Vue({
const vueProps = _extends({
name: 'shadow-root',
customElement: self,
shadowRoot: self.shadowRoot,
Expand All @@ -188,7 +197,9 @@ function wrap (Vue, Component) {
props: this.props
}, this.slotChildren)
}
});
}, !_isObjectEmpty(plugin) && _extends({}, plugin));

const wrapper = self._wrapper = new Vue(vueProps);

// Use MutationObserver to react to future attribute & slot content change
const observer = new MutationObserver(mutations => {
Expand Down
17 changes: 14 additions & 3 deletions dist/vue-wc-wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function getAttributes (node) {
return res
}

function wrap (Vue, Component) {
function wrap (Vue, Component, plugin) {
const isAsync = typeof Component === 'function' && !Component.cid;
let isInitialized = false;
let hyphenatedPropsList;
Expand Down Expand Up @@ -164,12 +164,21 @@ function wrap (Vue, Component) {
);
}

const _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };

function _isObjectEmpty(obj) {
return (
Object.prototype.toString.call(obj) === '[object Object]' &&
JSON.stringify(obj) === '{}'
);
}

class CustomElement extends HTMLElement {
constructor () {
const self = super();
self.attachShadow({ mode: 'open' });

const wrapper = self._wrapper = new Vue({
const vueProps = _extends({
name: 'shadow-root',
customElement: self,
shadowRoot: self.shadowRoot,
Expand All @@ -185,7 +194,9 @@ function wrap (Vue, Component) {
props: this.props
}, this.slotChildren)
}
});
}, !_isObjectEmpty(plugin) && _extends({}, plugin));

const wrapper = self._wrapper = new Vue(vueProps);

// Use MutationObserver to react to future attribute & slot content change
const observer = new MutationObserver(mutations => {
Expand Down
17 changes: 14 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
convertAttributeValue
} from './utils.js'

export default function wrap (Vue, Component) {
export default function wrap (Vue, Component, plugin) {
const isAsync = typeof Component === 'function' && !Component.cid
let isInitialized = false
let hyphenatedPropsList
Expand Down Expand Up @@ -78,12 +78,21 @@ export default function wrap (Vue, Component) {
)
}

const _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };

function _isObjectEmpty(obj) {
return (
Object.prototype.toString.call(obj) === '[object Object]' &&
JSON.stringify(obj) === '{}'
);
}

class CustomElement extends HTMLElement {
constructor () {
const self = super()
self.attachShadow({ mode: 'open' })

const wrapper = self._wrapper = new Vue({
const vueProps = _extends({
name: 'shadow-root',
customElement: self,
shadowRoot: self.shadowRoot,
Expand All @@ -99,7 +108,9 @@ export default function wrap (Vue, Component) {
props: this.props
}, this.slotChildren)
}
})
}, !_isObjectEmpty(plugin) && _extends({}, plugin));

const wrapper = self._wrapper = new Vue(vueProps)

// Use MutationObserver to react to future attribute & slot content change
const observer = new MutationObserver(mutations => {
Expand Down
3 changes: 2 additions & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import _Vue, { Component, AsyncComponent } from 'vue'

declare function wrap(
Vue: typeof _Vue,
Component: Component | AsyncComponent
Component: Component | AsyncComponent,
plugin?: any // update any to a better typing (i.e. VueConstructor...)
): HTMLElement

export default wrap