fix boolean attribute collapsing for v-bind shorthand (fix #73)

yyx990803 · yyx990803 · commit 271bf0ec80f8 · 2016-04-06T16:18:35.000-04:00
diff --git a/lib/compiler.js b/lib/compiler.js
@@ -18,14 +18,10 @@ if (process.env.NODE_ENV === 'production') {
   var htmlMinifier = require('html-minifier')
   // required for Vue 1.0 shorthand syntax
   var htmlMinifyOptions = {
-    customAttrSurround: [[/@/, new RegExp('')], [/:/, new RegExp('')]],
     collapseWhitespace: true,
     removeComments: true,
     collapseBooleanAttributes: true,
     removeAttributeQuotes: true,
-    // this is disabled by default to avoid removing
-    // "type" on <input type="text">
-    removeRedundantAttributes: false,
     useShortDoctype: true,
     removeEmptyAttributes: true,
     removeOptionalTags: true
diff --git a/test/expects/basic.js b/test/expects/basic.js
@@ -37,4 +37,4 @@ exports.default = {
   }
 };
 if (module.exports.__esModule) module.exports = module.exports.default
-;(typeof module.exports === "function"? module.exports.options: module.exports).template = "<h1 :id=id @click=hi>hello</h1><input type=text>"
+;(typeof module.exports === "function"? module.exports.options: module.exports).template = "<h1 :id=id @click=hi>hello</h1><input type=text> <button :disabled=loading>hihi</button>"
diff --git a/test/fixtures/basic.vue b/test/fixtures/basic.vue
@@ -7,6 +7,7 @@
 <template>
   <h1 :id="id" @click="hi">hello</h1>
   <input type="text">
+  <button :disabled="loading">hihi</button>
 </template>
 
 <script>

Original file line number	Diff line number	Diff line change
`@@ -37,4 +37,4 @@ exports.default = {`
`37`	`37`	`}`
`38`	`38`	`};`
`39`	`39`	`if (module.exports.__esModule) module.exports = module.exports.default`
`40`		`-;(typeof module.exports === "function"? module.exports.options: module.exports).template = "<h1 :id=id @click=hi>hello</h1><input type=text>"`
	`40`	`+;(typeof module.exports === "function"? module.exports.options: module.exports).template = "<h1 :id=id @click=hi>hello</h1><input type=text> <button :disabled=loading>hihi</button>"`