Skip to content

Remove cursor style from nav link container #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Remove cursor style from nav link container #620

merged 2 commits into from
Jul 3, 2018

Conversation

loilo
Copy link
Contributor

@loilo loilo commented Jun 28, 2018

Summary
The .nav-item div around each navbar link currently has an explicit cursor: pointer style. However it's slightly higher than its contained link. This makes the styling undesirable since it tricks the user into thinking that they could click there to follow the link.

  1. This pull request removes that style. It remains present on the link itself through the user agent stylesheet.

  2. Interactive nav items without any links (currently only dropdowns) should still be receiving their cursor style independently. This is also done by this pull request for the .dropdown-wrapper class.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Note how the cursor does not actually touch the link.

  • Before:
    before
  • After:
    after

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

It doesn't.

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Not done since change is really trivial. Done it anyway. Deploy preview makes things easy. 👍

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Not a feature.

@ulivz ulivz merged commit a0628df into vuejs:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants