Skip to content

Remove unnecessary minimize option for css-loader #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LinusBorg opened this issue Nov 13, 2017 · 2 comments
Closed

Remove unnecessary minimize option for css-loader #1056

LinusBorg opened this issue Nov 13, 2017 · 2 comments
Labels
enhancement

Comments

@LinusBorg
Copy link
Contributor

webpack/template/build/utils.js

Line 20 in 86d4970

minimize: process.env.NODE_ENV === 'production',

We shouldn't need this, since we use OptimizeCSSPlugin in the productionbuild anyway, right?

https://github.com/vuejs-templates/webpack/blob/develop/template/build/webpack.prod.conf.js#L54
c0defre4k added a commit to neonblack-at/webpack that referenced this issue Nov 17, 2017
@c0defre4k
Merge remote-tracking branch 'vuejs-templates/master'
4a883ef 
* vuejs-templates/master: (54 commits)
  v1.2.3
  remove double FriendlyErrorsPlugin (fix vuejs-templates#1064)
  v 1.2.2
  remove unnecessary minimize option (close vuejs-templates#1056)
  Make sure that imported css files in SFCs are autoprefixed, too (vuejs-templates#1053)
  reduce clientLogLevel
  remove `express` from package.json (vuejs-templates#1060)
  Remove extra commas (vuejs-templates#1050)
  1.2.1 - Bugfix release (vuejs-templates#1052)
  bumb version string in config in package.json
  bumb version string in config
  re-add postcss-loader
  Fix typos and formatting (vuejs-templates#1048)
  fix(jest): fix Jest coverage directory (vuejs-templates#1046)
  Remove unnecessary whitespaces (vuejs-templates#1047)
  re-merge (vuejs-templates#1045)
  Set ExtractTextPlugin.allChunks to true (vuejs-templates#1027)
  pass cssSourceMap option to vue-loader (vuejs-templates#756)
  Grammar and typo fixes on docs (vuejs-templates#992)
  Use webpack 3's standard way to generate a manifest in CommonsChunkPlugin (vuejs-templates#1028)
  ...

# Conflicts:
#	meta.js
#	template/config/index.js
#	template/index.html
#	template/package.json
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this issue Dec 25, 2017
@LinusBorg @frandiox
remove unnecessary minimize option (close vuejs-templates#1056)
cbc99c4
@maxiong1
Copy link

Why delete css-loader minimize: process.env.NODE_ENV === 'production'.
I know OptimizeCSSPlugin can compress；
but webpack.prod.conf.js new ExtractTextPlugin({ filename: utils.assetsPath('css/[name].[contenthash].css?v=111111')}),
Css packaged without compression did not go heavy

@LinusBorg
Copy link
Contributor Author

Please open a new issue and provide more information

shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
@LinusBorg
remove unnecessary minimize option (close vuejs-templates#1056)
2e5f91b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinusBorg @maxiong1