fix postcss config #890
Merged
fix postcss config #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688
LinusBorg
suggested changes
Sep 30, 2017
template/build/utils.js
Outdated
| // generate loader string to be used with extract text plugin | ||
| function generateLoaders (loader, loaderOptions) { | ||
| var loaders = [cssLoader] | ||
| var loaders = options.usePostCSS !== false ? [cssLoader, postcssLoader] : [cssLoader] |
There was a problem hiding this comment.
- Where does
option.usePostCSScome from? It's not to be found in/config/index.js, not in any of the webpack config files. This should be documented someway.
Is the idea to simply add it to the styleLoader code like this?
// in webpack.base.conf.js:
rules: utils.styleLoaders({ sourceMap: config.dev.cssSourceMap, usePostCSS: true })There was a problem hiding this comment.
Is the idea to simply add it to the styleLoader code like this?
// in webpack.base.conf.js: rules: utils.styleLoaders({ sourceMap: config.dev.cssSourceMap, usePostCSS: true })
Yes, I think the usePostCSS config should be set in the webpack config file.
added 2 commits
September 30, 2017 19:37
3b395e5 to
cdea8fe
Compare
LinusBorg
approved these changes
Sep 30, 2017
Merged
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Dec 25, 2017
* Update vue-loader link (vuejs-templates#886) * Merge some small fixes (vuejs-templates#900) * Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688 * fix postcss config * userPostCSS config
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
* Update vue-loader link (vuejs-templates#886) * Merge some small fixes (vuejs-templates#900) * Remove unused fs require from webpack.base.conf.js (vuejs-templates#893) * cleanup some leftover from reverting vuejs-templates#688 * fix postcss config * userPostCSS config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #600