Skip to content

Commit ea0c413

Browse files
committed
chore: merge branch master
2 parents 3477595 + db6df39 commit ea0c413

File tree

3 files changed

+22
-5
lines changed

3 files changed

+22
-5
lines changed

index.d.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ declare module 'nativescript-vue' {
1111
* @param resolver function to register the element
1212
* @param meta meta associated with the element
1313
*/
14-
static registerElement(elementName: string, resolver: Function, meta?: any);
14+
static registerElement(elementName: string, resolver: Function, meta?: any): void;
15+
16+
/**
17+
* starts the nativescript application
18+
*/
19+
$run(): void
1520
}
1621

1722
export = NativeScriptVue;

platform/nativescript/util/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function isUnknownElement(el) {
3131
}
3232

3333
export function isPage(el) {
34-
return el && el.tagName === 'page'
34+
return el && el.tagName === 'nativepage'
3535
}
3636

3737
/** @deprecated */

samples/app/app-with-pages.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,16 @@ const Vue = require('./nativescript-vue')
22

33
const App = {
44
template: `
5-
<StackLayout>
6-
<Button text="Open page" @tap="openPage" />
7-
</StackLayout>
5+
<Frame>
6+
<Page>
7+
<ActionBar class="action-bar" title="Home Page">
8+
<ActionItem text="Action"></ActionItem>
9+
</ActionBar>
10+
<StackLayout>
11+
<Button text="Open page" @tap="openPage" />
12+
</StackLayout>
13+
</Page>
14+
</Frame>
815
`,
916

1017
methods: {
@@ -16,11 +23,16 @@ const App = {
1623

1724
const DetailsPage = {
1825
template: `
26+
<Page>
27+
<ActionBar class="action-bar" title="Details Page">
28+
<ActionItem text="Action"></ActionItem>
29+
</ActionBar>
1930
<StackLayout>
2031
<Label :text="'Details ' + Math.random()" />
2132
<Button text="another" @tap="openDetails" />
2233
<Button text="back" @tap="goBack" />
2334
</StackLayout>
35+
</Page>
2436
`,
2537

2638
methods: {

0 commit comments

Comments
 (0)