Skip to content

fix(useDropZone): update isOverDropZone handling when elements inside the drag area use v-if #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(useDropZone): update isOverDropZone handling when elements inside the drag area use v-if #4665

wants to merge 2 commits into from
+4 −1

Conversation

ydkdev
Copy link

@ydkdev ydkdev commented Mar 19, 2025 •
edited by ilyaliao
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

fix: #4652

Reason Found: When the elements inside the drag area use v-if, moving the mouse away from those internal elements fails to trigger the dragleave event on them. This causes an error in the counter calculation, preventing isOverDropZone from being set to false.

Solution Approach: Add an extra condition to the existing logic to check whether the mouse is still within the drag area.

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 19, 2025
@ydkdev ydkdev mentioned this pull request Mar 19, 2025
Closed
5 tasks
@ydkdev
Copy link
Author

ydkdev commented Mar 26, 2025

@ilyaliao I’m new to open-source projects, and I noticed the bot saying there are 2 workflows awaiting approval. So, do I need to @ a collaborator to handle it? Or rather, what else do I need to do?

@ilyaliao
Copy link
Member

@ilyaliao I’m new to open-source projects, and I noticed the bot saying there are 2 workflows awaiting approval. So, do I need to @ a collaborator to handle it? Or rather, what else do I need to do?

Hi, sorry for the late reply.

Thank you for your contribution! You don't need to do anything else - just keep your PR fresh and wait patiently for maintainers to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG | useDropZone | isOverDropZone not reset to false
2 participants
@ydkdev @ilyaliao