Skip to content

feat(useFetch): add responseType to the beforeFetch context #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(useFetch): add responseType to the beforeFetch context #4690

wants to merge 2 commits into from

Conversation

aispin
Copy link

@aispin aispin commented Apr 3, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

在 BeforeFetchContext 接口中新增 responseType，其值为原代码中的 config.type。原因有两个：

  1. 用户可以在 beforeFetch 和 afterFetch 中添加依赖 responseType 的业务逻辑
  2. 在某种程度上来说，新增的responseType属性对齐了 axios 库对 AxiosResponse接口中的 request.responseType

Add responseType to the BeforeFetchContext interface, and its value is config.type in the original code. There are two reasons for this:

  1. Users can add business logic dependent on responseType in beforeFetch and afterFetch.
  2. To some extent, the newly added responseType property aligns with the request.responseType in the AxiosResponse interface of the axios library.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aispin