Skip to content

feat(useScrollParent): easily get the nearest scrollable parent #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(useScrollParent): easily get the nearest scrollable parent #4721

wants to merge 6 commits into from

Conversation

yue1123
Copy link

@yue1123 yue1123 commented Apr 21, 2025 •
edited
Loading

easily get the nearest scrollable parent reactively.

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Additional context

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 21, 2025
ferferga
ferferga reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@ferferga ferferga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, much cleaner, thank you! 🎉
Some other points you might have not come across!

Please, also update the tests to take into account the new regexes and x axis.

@yue1123
feat(useScrollParent): improve code and add x-axis support
8ef9a70 
- Improved types
- Full coverage test cases
- Improved element validation and fallback handling
@yue1123
Copy link
Author

yue1123 commented Apr 25, 2025

Apologies for the delay! I was focused on refining the test cases. Really appreciate your detailed code review and thoughtful suggestions!

@yue1123
Copy link
Author

yue1123 commented May 1, 2025

Apologies，I forgot to submit my comments.🤣

@yue1123
feat(useScrollParent): improve edge case handling
82007d7 
1. add includeHidden optional
2. support for fixed-position elements
3. Ensured absolute-positioned elements correctly skip static parent
ferferga
ferferga approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferferga ferferga ferferga approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer new function size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yue1123 @ferferga @antfu