fix(useElementVisibility): Resolve possible issue with once watcher inside of callback #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is more of a structural optimization, right? |
Yeah, it was a structural optimization. |
|
It looks good to me, but I'm not sure if this addresses the requirements described in #4704. |
Thanks for the review! |
OrbisK
reviewed
May 7, 2025
Comment on lines
+39
to
+48
| vi.mock('../watchOnce', () => { | ||
| return { | ||
| watchOnce: vi.fn((source, callback) => { | ||
| // Immediately execute the callback if the source is true | ||
| if (typeof source === 'object' && source.value === true) { | ||
| callback(true) | ||
| } | ||
| }), | ||
| } | ||
| }) |
There was a problem hiding this comment.
why do we need to mock this? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
fix #4704
Problem solved: The watchOnce call in useElementVisibility is happening inside of the intersection callback.
Solution: I moved the watchOnce call outside of the intersection callback to ensure it is only registered once when the composable is initialized.
Additional context