Skip to content

fix(onClickOutside): workaround for iOS #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented May 3, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

Fixes #4724

Additional context

However, it's useful to note that pointerdown event doesn't need this workaround. However, it's supported since Safari 13 where our baseline (Vue's 3 requirements) are Safari 10

Perhaps I should add a TODO comment about this so it can be reviewed at a later time if we change our browser support baseline?

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 4, 2025
@antfu antfu added this pull request to the merge queue May 4, 2025
Merged via the queue into main with commit 1c60c68 May 4, 2025
8 checks passed
@antfu antfu deleted the fix-safari-onClickOutside branch May 4, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG | onClickOutside| iOS workaround not working after #4479
2 participants