fix(useRouteParams): solve the problem of the default value remaining in the URL #4737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 12, 2025 17:47
…t "invisible and add id to the function config
…t "invisible and add id to the function config
OrbisK
requested changes
May 6, 2025
packages/core/useFileDialog/index.ts
Outdated
Comment on lines
40
to
44
| /** | ||
| * Set the id attribute for the input element (for accessibility and testing purposes). | ||
| */ | ||
| id?: string | ||
| } |
There was a problem hiding this comment.
we should wait for this: #4679
playgrounds/vite/src/App.vue
Outdated
Comment on lines
6
to
23
| // const userName=useRouteQuery('userName','Mike') | ||
| // userName.value='Mike' | ||
| const userId=useRouteParams('userId',123) | ||
| userId.value=1 | ||
| userId.value=999 | ||
| const route=useRoute() | ||
| const handleClick=()=>{ | ||
| console.log(userId.value); | ||
| console.log(route.fullPath); | ||
| console.log(route.path); | ||
| console.log(route.params); | ||
|
|
||
| // console.log(userName.value); | ||
| // console.log(route.fullPath); | ||
| // console.log(route.path); | ||
| // console.log(route.params); | ||
| // console.log(route.query); | ||
| } |
There was a problem hiding this comment.
please remove the playground changes 😅
| ../../README.md |
There was a problem hiding this comment.
this causes linting to crash
There was a problem hiding this comment.
Sorry, there might be some issues with the version of the code I submitted. I will adjust it immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR fixes #4732
The problem that occurred：
There is a default value, but it is not retained in the URL.
The judgment on whether to use the default value can only be made when assigning a value to the ref reference, which triggers the set function (and the judgment logic is incorrect).
solution：
Perform logical judgment outside the scope of the
setfunction. If there is a default value, add it to theparamand_paramsQueue.Inside the scope of the
setfunction, if a manual assignment is made, replace the default value.Move the code logic for updating the current
paramsparameter, which is currently placed in thenextTickfunction, outside thesetfunction. This way, it can break free from the constraint that theparamsof the current route can only be updated when a value is assigned to therefreference.test：
It has been thoroughly tested. When there is a default value and no manual assignment is made, the default value can be added to the
paramsparameter in theroute.Additional context
Please review whether my Pull Request (PR) is correct. If it is correct, I will continue to expand it to
useRouteQuery.