Initial attempt of serializer for useIDBKeyval #4781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. Can you add some tests for this feature to prevent future regressions? |
OrbisK
requested changes
Jun 4, 2025
Comment on lines
+89
to
+94
| if (serializer) { | ||
| data.value = serializer.read(rawValue) | ||
| } | ||
| else { | ||
| data.value = rawValue | ||
| } |
There was a problem hiding this comment.
maybe we should do this via default serializer. Like:
Suggested change
| if (serializer) { | |
| data.value = serializer.read(rawValue) | |
| } | |
| else { | |
| data.value = rawValue | |
| } | |
| data.value = serializer.read(rawValue) |
and
const {
flush = 'pre',
deep = true,
shallow = false,
onError = (e) => {
console.error(e)
},
writeDefaults = true,
serializer: {
read: (val)=>val,
write: (val)=>val,
}
} = options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to add
serializeroption touseIDBKeyvalto bring it more in line withuseStorageas per https://vueuse.org/core/useStorage/#custom-serializationCloses #4780