fix(useMouseInElement): fixing the issue where target element updates were not considered. #4782
+94
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issue where element movement was not considered.
ilyaliao
reviewed
May 29, 2025
| @@ -1,10 +1,13 @@ | |||
| import type { MaybeElementRef } from '../unrefElement' | |||
| import type { UseMouseOptions } from '../useMouse' | |||
| import { shallowRef, watch } from 'vue' | |||
| import { tryOnMounted } from '../../shared/tryOnMounted' | |||
There was a problem hiding this comment.
This should be imported from @vueuse/shared.
There was a problem hiding this comment.
Got it, thank you, it has been corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR enhances the useMouseInElement function to support scenarios where the target element may move or resize. It addresses cases where the element's position or dimensions change dynamically, which could lead to inaccurate mouse position calculations.
To solve this, useMutationObserver and useResizeObserver are used to watch for changes in the element's layout and update the internal state accordingly.
Additional context
No changes were made to the input or output of the function; the update is fully backward compatible.