-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat!: refactor components and make them consistent #4912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ilyaliao
wants to merge
55
commits into
vueuse:main
Choose a base branch
from
ilyaliao:refactor/components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,260
−466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that this kind of definition can handle the types of ![]() See f1907ef |
f1907ef
to
d685a59
Compare
… and slots support
…and slots support
… and slots support
d685a59
to
6305838
Compare
… and slot support
…s and slot support
…props and slot support
…finition and slot support
…n and slot support
…ion and slot support
…ition and slot support
…ition and slot support
…tion and slot support
…finition and slot support
…on and slot support
…n and slot support
…on and slot support
…inition and slot support
I've marked this as a |
antfu
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BREAKING CHANGE
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4911, I decided to systematically review every
@vueuse/components
component for props-related issues.This PR refactors
@vueuse/components
to improve type safety and DX.props
,emits
, andslots
.composable
return types forcomponent
usage.@vueuse/core
to prevent bundlers from inlining sub-entries.component
examples and docs.Props:
Emit:
Slot: