fix(useThrottleFn): align with traditional throttle behavior #4923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
This PR fixes an inconsistency in
useThrottleFn
's behavior whenleading: false
, making it behave more likelodash.throttle
.Previously, when
leading
was set tofalse
, the function could still execute on the second call if the first call was suppressed. This was becauselastExec
was not updated when the call was skipped, resulting in incorrectelapsed
calculation.This PR updates the logic to ensure that the throttle interval is respected properly, even when
leading: false
. This change aligns the behavior with developers’ expectations andlodash
's semantics.Fixes #4920.
Additional context
leading: false
, as the second call would unexpectedly pass through the throttle.Original issue discussion: [#4920](#4920)